TASEmulators / TASEmulators/BizHawk
{Sync,}Settings as record classes
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
As demonstrated in https://github.com/TASEmulators/BizHawk/commit/eef190d332e3560cdb82f5713b1fcf8e54f97dc1. Essentially codegen for clone (though we're using MemberwiseClone for that) and equality methods (see also my old notes on equality codegen).
I'm fairly certain it doeswith is just semantic sugar for a ctor call, but I've put this in the 2.9 Milestone as a reminder to check it works under Mono.
see also my notes on record struct
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the referenced BizHawk commit, then locate the Sync and Settings class definitions and review the linked equality notes. Confirm the intended record-class behavior, including MemberwiseClone-based cloning and generated equality, with the existing Mono constraint in mind; done means both settings types consistently provide the requested semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100