TASEmulators / TASEmulators/BizHawk
Global Emulator was `SystemId = "NULL"` briefly while loading movie because of double-click
Open
Nobody has claimed this yet.
App: EmuHawk
Open to design proposals only
Repro: Affects 2.8
Repro: Could not reproduce
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
This is reproducible on a slow Win10 machine—just spam the button in the Play Movie dialog.
Obvious fix would be adding locks to every click handler. Need to think of a better solution.
- edit: Does
[MethodImpl(Synchronized)]work? See my notes #165.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Play Movie dialog and reproduce the transient SystemId = "NULL" state on a slow Windows 10 machine by repeatedly clicking its button. Determine a solution that prevents the inconsistent loading state without simply adding locks to every click handler, then verify that rapid clicks no longer produce the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100