TASEmulators / TASEmulators/BizHawk
[F.Rq.] Pass player argument to `oninputpoll` callbacks
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
It would be nice if the oninputpoll event provided the lua script with which
controller port was polled, or if the lua script could indicate which
controllers to monitor.
It would be nice to have the onsavestate/onloadstate events tell the lua script
which state was saved/loaded.
Original issue reported on code.google.com by pjga...@gmail.com on 11 Nov 2014 at 2:08
edit: As far as I can tell, event.on{save,load}state already passed an argument to callbacks at the time the original ticket was opened (added 2012-03). Renaming this to be exclusively about oninputpoll. --yoshi
see also #3813/#4139
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the oninputpoll callback path and the Lua event bindings; the issue does not name specific files or tests. Confirm how controller ports are currently polled, then define done as callbacks receiving the polled player or controller argument and verify the existing oninputpoll behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, lua
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100