TASEmulators / TASEmulators/BizHawk
Incorrect SNES Disassembly of CMP
Open
Nobody has claimed this yet.
App: EmuHawk
Core: BSNES
Needs domain knowledge for triage
Repro: Affects 2.6
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
I find that an immediate CMP (Op Code: 0xC9) in the Debugger window reads and displays the next 2 bytes for the constant when it should be 1. I'm assuming it's not taking the M flag into account.
I'm using the BSNES core on BizHawk 2.6.0. I didn't see any relative fixes posted for 2.6.1.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the immediate CMP (0xC9) display in the Debugger window using the BSNES core, then trace the SNES disassembly handling for that opcode and its M flag. Done means the debugger displays one byte for the immediate constant when the M flag requires it, rather than two.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100