TASEmulators / TASEmulators/BizHawk
[Octoshock] "Emulate Sector Error Correction" option always works
@zeromus is already working on this.
Since Apr 2, 2021.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Summary
Disabling "Emulate Sector Error Correction" option has no effect. I changed a byte via a HEX editor in a BIN file (with EDC) and it was restored.
Repro
- Change any byte in the BIN file without rebuilding sector fields.
- Uncheck
PSX > Options > Emulate Sector Error Correction. - Load the game. The changed byte can be restored.
Host env.
- BizHawk 2.6.1; Win7 SP1 x64; AMD/AMD
Additional Info
I found a problematic commit https://github.com/TASVideos/BizHawk/commit/6b41bc28717077e12df259149d38b5b7ff4f75e0. EnableLEC is no longer used.
Before:
https://github.com/TASEmulators/BizHawk/blob/558de454a980186ee4f860b58f409e263a63d787/psx/octoshock/psx/cdc.cpp#L1034-L1046
After:
https://github.com/TASEmulators/BizHawk/blob/6b41bc28717077e12df259149d38b5b7ff4f75e0/psx/octoshock/psx/cdc.cpp#L1042-L1049
Current:
https://github.com/TASEmulators/BizHawk/blob/635fff6c5d574b161129d52a61ccead2e8897b0d/psx/octoshock/psx/cdc.cpp#L1058-L1065
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.