TASEmulators / TASEmulators/BizHawk
Prevent AssemblyResolve handler from loading non-bundled, undeclared deps
Open
Nobody has claimed this yet.
App: EmuHawk
Meta
Open to PRs for existing design
re: Security
Request: Feature/Enhancement
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
EmuHawk's deps are (or should be) known at compile-time, so we can codegen that list in. Then the event handler can reject any assembly which isn't in either that list or any ext. tool's ExternalToolAttribute.LoadAssemblyFiles list.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating EmuHawk's AssemblyResolve event handler and the ExternalToolAttribute.LoadAssemblyFiles usage. Trace how compile-time dependencies and external-tool assembly lists are identified, then verify that undeclared, non-bundled assemblies are rejected while listed assemblies continue to load.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100