TASEmulators / TASEmulators/BizHawk
"Float from Parent" option doesn't update properly
Open
Nobody has claimed this yet.
App: EmuHawk
Repro: Affects 2.6
Repro: Could not reproduce
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Summary
In TASStudio and Virtualpad the option "Float from Parent" gets saved, but doesn't update anything when that form opens.
Potential fix
Im guessing you're updating window styles/float from parent thing only on checkbox changed event. Maybe do that in form load event too.
Repro
- Open BizHawk (tested; happens on 2.6.0 and 2.4.0)
- Open VirtualPad/TASStudio
- Turn "float from parent" off
- Restart application
- Open VirtualPad/TASStudio
- Checkbox (menu checkbox) will be checked, but the form will still float from parent
Host env.
- BizHawk 2.6.0 and 2.4.0 (I didnt test other versions)
- Windows 10
- Ryzen 3 3200G
- 6 gb ram
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the TASStudio and Virtualpad windows and reproduce the saved "Float from Parent" state across an application restart. Trace where the menu checkbox is restored and where the window behavior is applied when the form opens. Done means the restored checkbox state and actual floating behavior agree in both windows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100