TASEmulators / TASEmulators/BizHawk

[Genesis core] CDL missing table jump data

Open
#2,588 6 comments 0 reactions 1 assignee View on GitHub

@nattthebear is already working on this.

Since Jan 20, 2021.

Core: Genplus-gx Tool: Code–Data Logger
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

Example. Game Toejam & Earl 2 (U)
here MOVE.W OFF(PC,D0.L),D0 logged as code
this opcode fetches one of the offsets in the table below
no table entries logged as data
so this one particular data fetch is missing from CDL (maybe there are others but this one I see for sure just now).

ROM:00023290 D080                                add.l   d0,d0           ; *c
ROM:00023292 303B 0806                           move.w  off_2329A(pc,d0.l),d0 ; *c
ROM:00023296 4EFB 0002                           jmp     off_2329A(pc,d0.w) ; *c
ROM:00023296                     ; ---------------------------------------------------------------------------
ROM:0002329A 0018                off_2329A:      dc.w sub_232B2-2-$23298 
ROM:0002329C 0034                                dc.w sub_232CE-2-$23298
ROM:0002329E 05C6                                dc.w sub_23860-2-$23298
ROM:000232A0 012A                                dc.w sub_233C4-2-$23298
ROM:000232A2 03C4                                dc.w sub_2365E-2-$23298
ROM:000232A4 028A                                dc.w sub_23524-2-$23298
ROM:000232A6 05C6                                dc.w sub_23860-2-$23298
ROM:000232A8 0474                                dc.w sub_2370E-2-$23298
ROM:000232AA 0512                                dc.w sub_237AC-2-$23298
ROM:000232AC 05C6                                dc.w sub_23860-2-$23298
ROM:000232AE 05C6                                dc.w sub_23860-2-$23298
ROM:000232B0 05A0                                dc.w sub_2383A-2-$23298
ROM:000232B2                     ; =============== S U B R O U T I N E =======================================
ROM:000232B2                     sub_232B2:   
ROM:000232B2 4A6A 000A                           tst.w   $A(a2)          ; *c
ROM:000232B6 6B00 05D2                           bmi.w   sub_2388A       ; *c
ROM:000232BA 08EA 0007 004B                      bset    #7,$4B(a2)      ; *c
ROM:000232C0 4A6A 000A                           tst.w   $A(a2)          ; *c
ROM:000232C4 6600 05C4                           bne.w   sub_2388A       ; *c
ROM:000232C8 08EA 0004 004B                      bset    #4,$4B(a2)      ; *c

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.