TASEmulators / TASEmulators/BizHawk
Movie Importer imports a blank LogKey
Open
Nobody has claimed this yet.
App: EmuHawk
Repro: Affects 2.6
Repro: Fixed/added in branch/fork
Repro: Regression from 2.4.2
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
As the title says, this has been an issue since 2.5, it worked in 2.4.2.
At the time ProcessMovieImport is called in MainForm, MovieSession.MovieController is the null controller.
That's as far as I could get so far.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in MainForm at the ProcessMovieImport call and inspect how MovieSession.MovieController is selected there, especially the null-controller case reported in the issue. Trace the Movie Importer’s LogKey source and compare the working 2.4.2 behavior with the regression introduced in 2.5. Done means imported movies receive a nonblank LogKey.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100