TASEmulators / TASEmulators/BizHawk

Should we ship a default config.ini instead of generating it?

Open
#2,544 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Meta Request: Feature/Enhancement
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

Currently, when config.ini (JSON) can't be loaded, we generate the file programmatically. I propose we ship a defcfg.json with releases which will be used in that case, as defctrl.json is. (Maybe these should be one file.)

A benefit of this change would be allowing distro-specific customisation by simply overwriting or patching the new file, whereas currently such customisation requires recompiling after patching source code. edit: NixHawk supports this, so it would only be for traditional distros and Windows, or forks of BizHawk.

This file would be different for win-x64 and linux-x64.

see also #2094

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how config.ini is loaded and generated, then compare that path with the existing defctrl.json handling. Define the platform-specific defcfg.json release files and verify that the loader uses them when config.ini cannot be loaded, while allowing distro-specific replacement or patching.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.