TASEmulators / TASEmulators/BizHawk
Allow changing sample rate for live playback (non-AV)
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Sound.SampleRate used to be a compile-time constant but is now a get-only prop. At first glance the *SoundOutput classes seem to be using it for init already, maybe no more changes are needed?
edit: from https://github.com/TASEmulators/BizHawk/issues/3207#issuecomment-1090656324:
Older consoles would fare much better with band-limited synthesis blip_buf provides. New consoles would fare much better with speex's resampler.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Sound.SampleRate and the *SoundOutput classes referenced in the issue, then trace how live non-AV playback initializes its audio output. Check the linked historical discussion for the intended resampling direction and confirm which output paths are in scope. Done means the live playback sample rate can be changed and the relevant behavior is covered by tests or a reproducible verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- audio-video-rtc, game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100