TASEmulators / TASEmulators/BizHawk
States can be loaded across movies with the same name but in different locations
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
As the title says, if you create movies of the same name in different locations, if you make a state in one you can load it into the other (as long as the frame counts match up.)
I would speculatively guess that this is probably the cause of some of the recent desync issues.
EDIT: Maybe each movie should have a unique hash code so that each state is only associated with that instead of the name?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by creating same-named movies in different locations, saving a state in one, and loading it in the other with matching frame counts. Trace the movie and state loading entry points to determine how movie identity is compared. Done means a state from one distinct movie cannot load into another merely because the names and frame counts match.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100