TASEmulators / TASEmulators/BizHawk

Change when/how movie length is calculated

Open
#2,198 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Meta Request: Feature/Enhancement
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

@alyosha-tas brought this up in #2197. There are actually a few reasons for this. One main reason is that loading movies for previewing currently requires loading the entire movie file so the frame count can be displayed. There are two potential solutions here: add a frame count field to the header so the movie's frame count can be previewed without excessive loading. Or just don't display the frame count in the preview.

Besides the basic slowness of loading entire movies just for the purpose of previewing them, I think there's some double-loading going on for some reason. Each movie appears to be loaded twice from some preliminary debugging.

Note: The double-loading is caused by the initial hash check loading the movies to check if the hash matches the current game (PlayMovie.MatchHashCheckBox_CheckedChanged), and then the movies actually being loaded for display (PlayMovie.PlayMovie_Load). (fixed in fe845ce8efae8fa3b11d04079d3ae20ec844ea8a)

2024-10-03 note: this is largely low priority for me now because of some efficiency improvements in other parts of the emulator since this issue was originally filed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the PlayMovie.MatchHashCheckBox_CheckedChanged and PlayMovie.PlayMovie_Load entry points, noting that the double-loading was fixed in fe845ce8efae8fa3b11d04079d3ae20ec844ea8a. Determine whether the intended outcome is header-based frame counts or hiding frame counts in previews, then verify that movie previews no longer require excessive loading.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.