TASEmulators / TASEmulators/BizHawk

Star Trek 25th Anniversary: Misaligned Border

Open
#2,125 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core: Gambatte Core: GBHawk Core: SameBoy (from 2.8) Inaccuracy Repro: Fixed/added in upstream stable Waiting on upstream
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

The border in the intro text screen is misaligned. You can see it in this video for example, where it's zoomed in and really obvious:

https://www.youtube.com/watch?v=KsthKsr_2Sw&t=32s

You can also see it in this video, where it appears to be played on a gameboy player:

https://www.youtube.com/watch?v=HCmIQ24AMgo&t=62s

However, there are 2 videos where the border is properly aligned, one is played on SGB:

https://www.youtube.com/watch?v=bEArrvHV6wQ&t=181s

The other I'm not sure about:

https://www.youtube.com/watch?v=K-4r30hHwsA

The game uses the Window in a non-standard way. The top few scanlines are part of the window, then it turns off the window and the normal background is used for the text part, then turns the window back on for the bottom of the screen.

If the background is emulated normally, then it is in fact misaligned. If you look at the 2 videos with proper alignment, there is a clear blank vertical line on the left side of the screen. So, for some reason the background is being shifted to the right one pixel for the alignment to work out.

This one needs some console testing probably, since it could be it only works on original GB, or only on SGB, and maybe the behaviour was 'fixed' for CGB since the GBP video shows it misaligned again (if that is in fact real hardware.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the intro screen on the original Game Boy, Super Game Boy, Game Boy Color, and Game Boy Player where possible, comparing the border alignment with the linked videos. Investigate the emulator's handling of the game's non-standard window usage and determine which hardware behavior is correct. Done means the border matches the appropriate real-hardware behavior across the tested systems.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.