TASEmulators / TASEmulators/BizHawk

Locked SaveRAM files are not handled gracefully

Open
#1,466 5 comments 0 reactions 1 assignee View on GitHub

@zeromus is already working on this.

Since Jan 28, 2019.

App: EmuHawk Repro: Patch pending
Dominant language
C#
Stars
2.8k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

I've been trying out File > Save RAM > Flush Save Ram and found that if the save file is locked, the command silently fails with no notice.

I've also had an exception thrown upon exiting a game through File > Close Rom because the SaveRAM is locked.

It would be preferable in both cases if a dialog box appeared telling the user that the file is locked for editing, and allowing them to try again or skip saving.

I'm using BizHawk Version 2.3.1 (x64) on Windows 8.1.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.