TASEmulators / TASEmulators/BizHawk
PeekByte() on parts of the Apple II system bus results in crash (scrolling in the hex editor)
Open
@Asnivor is already working on this.
Since Dec 7, 2018.
Core: Virtu
- Dominant language
- C#
- Stars
- 2.8k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
If you load up the Apple II core, open the hex editor, swap the domain to the System Bus, and try scrolling to the bottom, Bizhawk will crash with the following exception:
at Jellyfish.Virtu.DiskIIDrive.get_IsWriteProtected()
at Jellyfish.Virtu.DiskIIController.ReadIoRegionC0C0(Int32 address)
at Jellyfish.Virtu.Memory.ReadIoRegionC0C0(Int32 address)
at Jellyfish.Virtu.Memory.ReadIoRegionC0CF(Int32 address)
at Jellyfish.Virtu.Memory.Peek(Int32 address)
at BizHawk.Emulation.Cores.Computers.AppleII.AppleII.<SetupMemoryDomains>b__85_2(Int64 addr) in C:\Users\Daniel\Documents\BizHawk\BizHawk.Emulation.Cores\Computers\AppleII\AppleII.IMemoryDomains.cs:line 44
at BizHawk.Client.EmuHawk.HexEditor.MakeValue(Int32 dataSize, Int64 address, Boolean& is_cheat) in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\tools\HexEditor\HexEditor.cs:line 603
at BizHawk.Client.EmuHawk.HexEditor.GenerateMemoryViewString(Boolean forWindow) in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\tools\HexEditor\HexEditor.cs:line 539
at BizHawk.Client.EmuHawk.HexEditor.UpdateValues() in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\tools\HexEditor\HexEditor.cs:line 156
at BizHawk.Client.EmuHawk.ToolManager.UpdateAfter() in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\tools\ToolManager.cs:line 445
at BizHawk.Client.EmuHawk.ToolManager.UpdateToolsAfter(Boolean fromLua) in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\tools\ToolManager.cs:line 673
at BizHawk.Client.EmuHawk.MainForm.StepRunLoop_Core(Boolean force) in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\MainForm.cs:line 2988
at BizHawk.Client.EmuHawk.MainForm.ProgramRunLoop() in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\MainForm.cs:line 483
at BizHawk.Client.EmuHawk.Program.SubMain(String[] args) in C:\Users\Daniel\Documents\BizHawk\BizHawk.Client.EmuHawk\Program.cs:line 227
Latest dev build
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.