Sylius / Sylius/SyliusResourceBundle

Update rector.php config to php8.0 and constructor property promotion in particular

Open
#752 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Maintenance
Dominant language
PHP
Stars
235
Forks
166
PR merge metrics
No merged PRs in 30d

Description

Describe the proposed solution
Current rector.php config is last configured for php 7.4
https://github.com/Sylius/SyliusResourceBundle/blob/3449806cab35baa973a2e2398efc3137b0695608/rector.php#L10-L18

Let's update it up to php8.0 like in sylius/sylius

image

https://github.com/Sylius/Sylius/blob/1.13/rector.php

Additional context
After https://github.com/Sylius/SyliusResourceBundle/pull/749 will be merged

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open rector.php and compare its current PHP 7.4 configuration with the referenced Sylius 1.13 rector.php. Check the changes after pull request #749 is merged, update the configuration for PHP 8.0 including constructor property promotion, and confirm the resulting Rector configuration is valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.