Sylius / Sylius/Stack

Are SVGs in this file icons or something else? Should they be moved to external macro?

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
45
Forks
34
PR merge metrics
No merged PRs in 30d

Description

          Are SVGs in this file icons or something else? Should they be moved to external macro?

Originally posted by @diimpp in https://github.com/Sylius/Stack/pull/31#discussion_r1763579741

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the discussion from pull request #31, linked in the issue body, and identify which file contains the questioned SVGs. Determine whether they are icons and whether extracting them to an external macro is appropriate; done means the decision and resulting scope are documented clearly enough for implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.