Sylius / Sylius/Stack

Not sure what this hardcoded locale does, but there should be locale value available at `{{ app.locale }}` (Or some similar property)

Open
#38 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
PHP
Stars
45
Forks
34
PR merge metrics
No merged PRs in 30d

Description

          Not sure what this hardcoded locale does, but there should be locale value available at `{{ app.locale }}` (Or some similar property)
                <a class="dropdown-item{{ item.class ? extra_class }}" href="{{ item.url }}" {{ sylius_test_html_attribute('user-dropdown-item', item.title|trans({}, null, app.locale)) }}>

Originally posted by @diimpp in https://github.com/Sylius/Stack/pull/30#discussion_r1763126739

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the dropdown-item template snippet in the original pull-request discussion and inspect the locale argument currently passed to the translated item title. Confirm which app locale value is available there, then verify the dropdown renders translations using that value instead of the hardcoded locale argument.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
frontend, internationalization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.