Should `isDynamicPattern` be a replacement for `is-glob`?

Open
#71 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Start with the linked commit, especially the diff around line 5, and reproduce the test failures from the attempted swap. Compare the behavior of isDynamicPattern and is-glob in the affected tests; done means determining whether the dependency replacement is compatible and leaving the tests passing if it is.

Written by the indexing model from the issue text.

Description

question

I thought it might allow us to get rid of some more dependencies, but it didn't seem to work when I tried swapping them. Not quite sure why the tests are failing, but you can see my attempt here:

https://github.com/benmccann/json-schema-to-typescript/commit/2a79b100c4e711682e2c5125a78246e4c89dd6c4#diff-fa8d4e24d8399e8350f1c8bad05df53e8032ea995835bf911507015e2db61cddR5

Dominant language
TypeScript
Stars
544
Forks
30
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SuperchupuDev/tinyglobby

All issues in SuperchupuDev/tinyglobby

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.