Starfish-develop / Starfish-develop/Starfish

global_cov:log_amp reasonable values for the sigma-contours plot?

Open
#148 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
78
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Hi,

We are trialling starfish to see if we can implement some of your ideas here into our groups existing radiative transfer work.

We have your example files (setup.ipynb/single.ipynb) and it all runs smoothly apart from the sigma-contours are enormous (1e8) on the residuals plot. Example below.

Screenshot 2022-12-13 at 10 57 43

We have managed to reduce this error through changing the log_amp parameter in the SpectrumModel(...) function to -11 (instead of 38) and changing the priors "global_cov:log_amp" value to (-11, 3) instead of (38,1). For us, this produces a similar looking plot to the readthedocs example. Numbers and plot below

Screenshot 2022-12-13 at 11 06 45

Is a log_amp value of -11 considered to be okay/reasonable and normal behaviour?

As this seems significantly different to the original.
I'm not sure if you have changed something in the code since the readthedocs was written that might account for this difference?

The only other difference we had noted was the numbers outputted from training the emulator was different, such as the log likelihood. Does this all sound okay? Numbers from initial and secondary training below.

1st
Screenshot 2022-12-13 at 11 18 12
2nd
Screenshot 2022-12-13 at 11 18 18

This was verified by my supervisor on a separate machine. We both produced identical log-likelihood numbers of the emulator training session and in turn, identical log_amp numbers. Starfish version 0.4.2

Many thanks,
Austen

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running setup.ipynb and single.ipynb with Starfish 0.4.2, then inspect SpectrumModel(...) and the global_cov:log_amp prior used in those examples. Compare the sigma-contours and emulator-training outputs with the ReadTheDocs example; done means determining whether the differing log_amp and likelihood values are expected or identifying the cause of the discrepancy.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization, machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.