StackStorm / StackStorm/st2

Pack rule operator exists / nexists should not have criteria pattern mandatory

Open
#6,197 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

SUMMARY

When using exists / nexists rule operator, we need to provide a criteria pattern which is not correct, as the value of this pattern needs to be null / should not be there.

STACKSTORM VERSION

st2 3.7.0, on Python 3.6.8

OS, environment, install method

Running on Docker in Mackbook Pro (x86)

Steps to reproduce the problem

Use exists / nexists rule operator in criteria section. Omit the value of criteria pattern (as it is not needed for this operator).

criteria:
  trigger.org_id:
    type: exists

Expected Results

The pack should get installed correctly as all information is available.

Actual Results

Pack installation fails and we need to add a pattern field unnecessarily.

criteria:
  trigger.org_id:
    type: exists
    pattern: "placeholder"

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace pack installation and criteria validation for the exists and nexists rule operators, using the reproduction snippets in the issue as the starting case. Verify how other operators validate pattern values. Done means a pack containing an exists or nexists criterion without pattern installs successfully, while invalid criteria remain rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.