StackStorm / StackStorm/st2

The secrets are shown in plain text in Rules/Enforcements tab on WebUI

Open
#5,809 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug security
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

SUMMARY

The action parameter with secret: true is shown in plain text on Rules/Enforcements section on WebUI

STACKSTORM VERSION

st2 3.7.0, on Python 3.8.12

OS, environment, install method

RedHat 8.6

Steps to reproduce the problem

---
name: full_backup
pack: mongodb
enabled: true
description: Performs a backup of MongoDB
runner_type: orquesta
entry_point: workflows/full_backup.yaml
parameters:
  mongodb_password:
    default: "{{ st2kv.system.mongodb_admin_password | decrypt_kv }}"
    type: string
    secret: true
---
name: mongodb_backup_cron
pack: backups
description: "Executes a mongodb backup on a cron schedule."
enabled: true

trigger:
  type: "core.st2.CronTimer"
  # http://apscheduler.readthedocs.io/en/3.0/modules/triggers/cron.html#api
  parameters:
      timezone: "UTC"
      day_of_week: "*"
      hour: 1
      minute: 0
      second: 0
  
action:
  ref: "backups.mongodb_backup"

Expected Results

The parameter mongodb_password should be masked on Web UI in Rules/Enforcements tab, no plain text should be displayed

Actual Results

The parameter mongodb_password is shown in plain text in Action input in the Rules/Enforcements tab on Web UI

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the WebUI Rules/Enforcements tab using an action parameter with secret: true, then inspect how its Action input is displayed. Done means the mongodb_password value is masked and no plain-text secret appears in that tab.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.