StackStorm / StackStorm/st2

Add tests for all linux pack actions

Open
#4,999 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug complexity:easy good first issue packs tests
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

The contrib linux pack has a few broken actions (check_loadavg, check_processes, dig: #4993, diag_loadavg, netstat: #4947, possibly more) at least on CentOS 8. It's really disheartening to spin up StackStorm and immediately run into broken actions.

We should add tests for those actions to the pack.

The tests from the core pack can be used as a template for writing tests for the linux pack.

I will try to add tests for the dig action in my PR #4993, to serve as a concrete example, but adding tests would be a useful way to introduce somebody to developing StackStorm that would have an immediate impact.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the tests in contrib/core/tests with the actions in contrib/linux, especially check_loadavg, check_processes, dig, diag_loadavg, and netstat. Use the core tests as the stated template and review PR #4993 for the dig example. Done means the linux pack has tests covering its actions, including the currently reported broken ones.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.