Fault-tolerance configuration for messaging/rabbitmq
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 787
- PR merge metrics
- No merged PRs in 30d
Description
@nmaludy asked to open an issue to discuss making certain retry parameters configurable.
The idea here is to make at least these two configurable via st2.conf:
I see them in the [messaging] section: https://github.com/StackStorm/st2/blob/v3.2/conf/st2.conf.sample#L183-L203
And also make the following errors visible without enabling debug to allow users see/monitor errors affecting st2 performance:
- https://github.com/StackStorm/st2/blob/v3.2/st2common/st2common/transport/connection_retry_wrapper.py#L143-L144
- https://github.com/StackStorm/st2/blob/v3.2/st2common/st2common/transport/connection_retry_wrapper.py#L155-L156
And last, but not least, perhaps it'd be nice to implement rabbitmq heartbeat feature to ensure connections are kept alive if they are traversing firewalls or other connection trackers?
Per @nmaludy :
heartbeat (float) – Heartbeat interval in int/float seconds. Note that if heartbeats are enabled then the heartbeat_check() method must be called regularly, around once per second.
Which, I believe, is not being used within st2 source code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with st2common/transport/connection_retry_wrapper.py at the referenced retry parameters and error-handling lines, then compare them with the [messaging] section in conf/st2.conf.sample. Review how RabbitMQ connections are created and whether heartbeat_check() is called. Done means the retry settings, operational errors, and heartbeat behavior have clear configuration and verification coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, rabbitmq
- Domain
- backend, distributed-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100