StackStorm / StackStorm/st2

Chatops keyword parameter passing broken

Open
#4,707 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug chatops status:to be verified
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

SUMMARY

I upgraded stackstorm to the new 3.0.1 and our way of calling slack chatops with named parameter is not working any more.

!newbuild name=truc gittag=c4deadbeefd03266f1ba7042b14b31a release=unstable github_packaging_branch=10.32

output:

I'm sorry, Dave. I'm afraid I can't do that.
Command "newbuild name=truc gittag=c4deadbeefd03266f1ba7042b14b31a release=unstable github_packaging_branch=10.32" doesn't match format string "newbuild {{name=truc}} {{gittag}} {{release}} {{github_packaging_branch}}"

whereas the following is OK:

!newbuild truc c4deadbeefd03266f1ba7042b14b31a unstable "10.32"

This was working fine before.

ISSUE TYPE
  • Bug Report
STACKSTORM VERSION

st2 3.0.1, on Python 2.7.5

OS / ENVIRONMENT / INSTALL METHOD

Bare-metal CentOS 7 + EPEL (up to date)

STEPS TO REPRODUCE
!say phrase=toto in color=red
EXPECTED RESULTS
I have it covered. Your execution ID is 5cfa92a935e378177eae1d39 (details available at https://stackstorm.novalocal/#/history/5cfa92a935e378177eae1d39/general)
@Vincent:
Noop
Action core.noop completed.
status : succeeded
execution: 5cfa92a935e378177eae1d39

web_url: https://stackstorm.novalocal/#/history/5cfa92a935e378177eae1d39/general

Took 0.459185\u03BCs to complete.

result :
--------
failed : False
 Show more
ACTUAL RESULTS
@You: I'm sorry, Dave. I'm afraid I can't do that.
Command "say phrase=toto in color=red" doesn't match format string "say {{phrase}} in {{color}}"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified in the report. Start by reproducing the regression with the !say phrase=toto in color=red and !newbuild named-parameter commands on StackStorm 3.0.1; done means those commands parse successfully and produce the expected execution output rather than a format-mismatch error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.