StackStorm / StackStorm/st2

`st2 pack install` will ignore failures when installing multiple packs

Open
#4,620 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug CLI complexity:easy good first issue
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

SUMMARY

If I attempt to install multiple packs using st2 pack install, and one of those packs is non-existent, it will silently ignore the failure.

ISSUE TYPE
  • Bug Report
STACKSTORM VERSION

st2 3.0dev (d86747c), on Python 2.7.12

OS / ENVIRONMENT / INSTALL METHOD

one-line install.

STEPS TO REPRODUCE
extreme@ubuntu:~$ st2 pack install foobar acos

For the "foobar, acos" packs, the following content will be registered:

rules     |  0
sensors   |  0
aliases   |  0
actions   |  19
triggers  |  0

Installation may take a while for packs with many items.

	[ succeeded ] download pack
	[ succeeded ] make a prerun
	[ succeeded ] install pack dependencies
	[ succeeded ] register pack

+-------------+-----------------------------------------------+
| Property    | Value                                         |
+-------------+-----------------------------------------------+
| name        | acos                                          |
| description | Manage ACOS-based appliances of A10 Networks. |
| version     | 0.2.5                                         |
| author      | Hiroyasu OHYAMA                               |
+-------------+-----------------------------------------------+
extreme@ubuntu:~$
EXPECTED RESULTS

I expected some error message about "pack foobar not found", similar to if I had just tried st2 pack install foobar

ACTUAL RESULTS

Install completes 'successfully', since one pack install works.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing st2 pack install foobar acos and compare it with st2 pack install foobar. Trace the st2 pack install entry point and its handling of multiple pack names. Done means a missing pack produces an error while the valid pack's installation result remains reported.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.