StackStorm / StackStorm/st2

Nested Key marked as secret in pack config schema showing as plain text in WebGUI

Open
#4,448 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug security
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

SUMMARY

Seen in the zabbix pack. A nested key in the zabbix pack config that is marked as secret: true is still being shown in plain text in the webgui.

ISSUE TYPE
  • Bug Report
STACKSTORM VERSION

Paste the output of st2 --version:
st2 2.9.1, on Python 2.7.12

OS / ENVIRONMENT / INSTALL METHOD

Ubuntu 16.04 LTS One line install

STEPS TO REPRODUCE

Fresh install of st2 2.9.1 on Ubuntu 16.04 LTS
Install Zabbix pack from webgui
Configure as below

Config

zabbix:
  password: R******$
  url: https://zabbix*******
  username: s******t

image

EXPECTED RESULTS

The key password: should shows as ******

ACTUAL RESULTS

The key password: should shows as plain-text

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the zabbix pack configuration shown in the report, focusing on the nested password field marked secret. Trace how the pack config schema is rendered in the WebGUI and verify that the password is masked rather than displayed as plain text.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.