Implement rate limiting for st2auth /tokens API endpoint (aka authenticate endpoint)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 787
- PR merge metrics
- No merged PRs in 30d
Description
We should implement rate limiting on per user basis on the st2auth authenticate API endpoint.
There should be no need for single user to authenticate more than some reasonable amount of times in a short time frame (e.g. 10 in 60 seconds).
Authenticating more than some reasonable amount of times could put unnecessary stress on the upstream authentication backend server in some situations (e.g. when LDAP backend is used).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the st2auth /tokens API endpoint, also called the authenticate endpoint, and locate its existing request handling and tests. Define and verify a per-user short-window authentication limit, including the response when the limit is exceeded, while preserving normal authentication behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, authentication, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100