Sensor container should generate and manage auth tokens for sensor processes
Open
@Kami is already working on this.
Since Nov 8, 2017.
complexity:medium
enhancement
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 787
- PR merge metrics
- No merged PRs in 30d
Description
Right now each sensor wrapper / process creates it's own token which is used for datastore service access purposes (contributed by Plexxi a while ago).
New auth token gets generated every time a sensor starts up. This token is valid TTL number hours and doesn't get cleaned up if the sensor is shut down or crashes.
We should improve that and follow the same abstraction we use for action runners - tokens should be created and managed by the sensor container service and they should be cleaned up when a sensor dies / crashes / similar. This way we don't have ghost tokens laying around in the database.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.