StackStorm / StackStorm/st2

Do not install linux pack on osx machine

Open
#3,785 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

deployment enhancement
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

While we don't support OSX directly, I still think it makes sense to note it here: make requirements fails on inotify is not available on macosx-10.12-intel.

Pyinotify is both direct and transitive (through logshipper) dependency of linux pack. It makes little sense to try and install it on OSX machine anyway. If we are to prevent linux pack from being installed on osx machine, the rest inside the makefile seem to work alright.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Makefile target behind make requirements and trace how the linux pack and its pyinotify dependency through logshipper are selected. Verify the OSX path, then make linux pack installation skip OSX while the remaining requirements still install successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.