Python runner should throw an exception when action result can't be serialized
@Kami is already working on this.
Since Jun 30, 2017.
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 787
- PR merge metrics
- No merged PRs in 30d
Description
Right now if the result can't be serialized we return str() version of the result, but I believe the right approach would be to throw an exception in such scenario.
str() version of the result is usually of little use and not being able to de-serialize the result usually indicates a programmer error (action / pack developer didn't correctly implement de-serialization of the result in format which can be consumed in StackStorm).
If people strongly believe there still is some value in str() version of the result we can add allow_non_serializable_results Python runner config option which should default to false.
For details, see: #3489, #3540.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.