StackStorm / StackStorm/st2

`st2-self-check` fails on older st2 versions

Open
#3,095 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue tests
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

We YOLO-pull st2tests master in st2-self-check script. This makes script broken on older st2 versions.

So st2-self-check should rely on versioned branches in st2tests.

TODO: Parse https://github.com/StackStorm/st2/blob/master/st2common/st2common/__init__.py to determine the correct git vX.Y branch to get.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with st2common/bin/st2-self-check and inspect the version information in st2common/st2common/init.py. Trace how the script currently retrieves st2tests, then use the matching versioned vX.Y branch instead of master. Done means older st2 versions select a compatible st2tests branch without breaking the self-check.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.