StackStorm / StackStorm/st2

Refactor ResourceRegistrar classes (reduce duplicated code)

Open
#2,705 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

complexity:easy refactor stale
Dominant language
Python
Stars
6.5k
Forks
787
PR merge metrics
No merged PRs in 30d

Description

We should refactor all the common resource registrar code and move it to the base class. Actual resource-specific classes should just contain a small amount of meta-data (which API model to use, which persistence class to use, etc).

I've already done a pass in the past, but there is still way too much of duplicated code and by refactoring it, we can get rid of substantial amount of duplicated code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name specific files, tests, or entry points. Begin by locating the ResourceRegistrar subclasses and their base class, inventory the duplicated behavior, and determine whether the shared code can move safely; done means resource-specific classes contain only metadata and the existing test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.