Windows runner does not detect `winexe` installed until ST2 restarted
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.5k
- Forks
- 787
- PR merge metrics
- No merged PRs in 30d
Description
I think the import level detection is what is causing the problem. If st2 is already up and then you install winexe, st2 won't detect winexe until there is a restart. Moving the detection to inside the container of BaseWindowsRunner class will fix it.
https://github.com/StackStorm/st2/blob/master/st2actions/st2actions/runners/windows_runner.py#L30
Reported by: Tracy Teague on community. (Also offered to open a PR)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect st2actions/st2actions/runners/windows_runner.py around line 30 and the BaseWindowsRunner class. Start by reproducing the case where winexe is installed after st2 starts, then verify that the Windows runner detects it without requiring a restart.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100