StackGuardian / StackGuardian/tirith
fix(terraform_plan): widen `provider_config` — remove `SUPPORTED_ATTRIBUTES`, fix two live bugs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 165
- Forks
- 42
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 11
Description
~10 lines unlocking hardcoded-credential checks across many providers' provider blocks. On the way, fix:
provider_config_operator uses return instead of continue (handler.py:279), so with two
aliased provider blocks a miss on the first silently drops the second; and the resource_changes
short-circuit at handler.py:67 means a credential check cannot fail on a no-op plan — verified
final_result: None with a hardcoded password sitting in configuration.provider_config.
Redaction needs a sentinel substitution rather than key deletion, with the local-vs-platform
verdict difference documented.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading handler.py around lines 67 and 279, then trace how provider_config is filtered by SUPPORTED_ATTRIBUTES and how aliased provider blocks are processed. Verify behavior with a no-op plan and multiple aliased providers containing hardcoded credentials. Done means provider_config checks cover the intended providers, both live bugs are fixed, redaction uses a sentinel substitution, and the local-versus-platform verdict difference is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, terraform
- Domain
- devops, infrastructure, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100