StackGuardian / StackGuardian/tirith
Deduplicate result message logic
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 165
- Forks
- 42
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 11
Description
Taking this from https://github.com/StackGuardian/tirith/pull/254#discussion_r2086488068
It'd be nice if we could have something a method in the BaseEvaluator that just does this. And the child classes can just pass the intermediary string like is less than, etc
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the BaseEvaluator entry point and the child evaluators that construct result messages, then review the linked pull-request discussion for the original context. Done means the shared result-message logic lives in BaseEvaluator and child classes provide only the intermediary comparison string, with existing behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100