StackExchange / StackExchange/Stacks

When a post is both "watched" and "deleted", the background color styling for deleted should take precendence

Open
#957 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
672
Forks
107
Avg merge
2d 12h
Merged PRs (30d)
26

Description

When a post is both "watched" and "deleted", the watched styling takes precedence instead of the deleted styling. In my opinion, it should be the other way around (the fact it's deleted is more important than the fact it's watched).

Specifically, a post that has .s-post-summary__deleted and .s-post-summary__watched will have it's background color set to the watched value.

Here is a screenshot showing four posts:

  • a deleted post with red background
  • a watched & delete post with the yellow background (this is the one I think should be red)
  • a watched post with yellow background
  • a normal post with neither watched or deleted

image

Note that the style appears to come from primary.css instead of stacks.css:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the .s-post-summary__deleted and .s-post-summary__watched styles in primary.css and stacks.css, starting with the selectors that set their background colors. Confirm the combined classes use the deleted styling, then verify the four post states shown in the issue still have the expected backgrounds.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
design
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.