StackExchange / StackExchange/Stacks

Improve wrapping of `.s-progress--label`

Open
#809 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
672
Forks
107
Avg merge
2d 12h
Merged PRs (30d)
26

Description

.s-progress--labels that wrap don't affect the height of its' parent. This could be seen as a feature instead of a bug, but it results in some kinda ugly elements.

See also: https://github.com/StackExchange/Stacks/pull/807#pullrequestreview-834542062

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the wrapping behavior shown in the issue and inspecting the styles for .s-progress--label; the related review in pull request #807 may provide context. Done means wrapped labels contribute to the parent’s height and the resulting progress elements no longer appear visually broken.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.