StackExchange / StackExchange/Stacks

Component: include the linenum JS as part of stacks for Link Previews

Open
#456 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
672
Forks
107
Avg merge
2d 12h
Merged PRs (30d)
26

Description

Following up on #449, @gdalgas wants to:

Would it be possible to include the linenum JS as part of stacks instead of relying on a modified 3rd party library? That way we could have full control over things like naming and implementation. We are using prettify for this currently: https://wet-boew.github.io/v4.0-ci/demos/prettify/prettify-en.html

Yes, let's do that! Aaron suggested changing linenums to s-link-preview--linenumbers while we're there.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Link Previews stack integration and search for the existing linenums usage and modified prettify dependency. Confirm how the linenum JavaScript is included in Stacks, then update the naming to s-link-preview--linenumbers. Done means Link Previews retain working line numbers without relying on the modified third-party library.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.