StackExchange / StackExchange/StackExchange.Redis
Change value type of KeyRestore from byte[] to ReadOnlyMemory<byte>
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.2k
- Forks
- 1.6k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Description
Change please type byte[] value
from
void KeyRestore(RedisKey key, byte[] value, TimeSpan? expiry = null, CommandFlags flags = CommandFlags.None)
Task KeyRestoreAsync(RedisKey key, byte[] value, TimeSpan? expiry = null, CommandFlags flags = CommandFlags.None)
to
void KeyRestore(RedisKey key, ReadOnlyMemory value, TimeSpan? expiry = null, CommandFlags flags = CommandFlags.None)
Task KeyRestoreAsync(RedisKey key, ReadOnlyMemory value, TimeSpan? expiry = null, CommandFlags flags = CommandFlags.None)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the KeyRestore and KeyRestoreAsync entry points in the repository. Compare their current signatures with the requested ReadOnlyMemory forms and check the surrounding restore coverage; done means both signatures match without changing the stated parameters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, redis
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100