StackExchange / StackExchange/StackExchange.Redis
HashSet uses HMSET which has been depcrecated for a while
Open
Nobody has claimed this yet.
⚙️ area:API
➕ enhancement
- Dominant language
- C#
- Stars
- 6.2k
- Forks
- 1.6k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Description
The following snippet:
db.HashSet("some-key", new HashEntry[] {new("foo", 1), new ("bar", 2)});
Translates to:
HMSET some-key foo 1 bar 2
Given that HMSET is considered deprecated as of Redis 4.0.0 and that HSET now supports multiple pairs, can db.HashSet be updated?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the db.HashSet entry point and trace how the HashEntry array is translated into a Redis command. Check the existing command-related tests, then update the behavior so multiple hash pairs use HSET rather than HMSET and verify the tests cover the resulting command.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, redis
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100