Stability-AI / Stability-AI/stable-audio-3

Pointing to local folder in python does not really work

Open
#35 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
763
Forks
96
Avg merge
3h 4m
Merged PRs (30d)
4

Description

This makes absolutely no sense, when the model_name_or_path is actually validated against the static list later on
def from_pretrained(model_name_or_path, device=None, model_half=True):

if model_name_or_path not in all_models: <-- This cannot ever contain the local path
raise ValueError(
f"Unknown model '{model_name_or_path}'. Valid models: {list(all_models)}"
)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the from_pretrained(model_name_or_path, device=None, model_half=True) entry point and trace how model_name_or_path is checked against all_models. Reproduce the failure with a local folder, then verify that local paths are accepted without breaking validation of named models.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.