Spoje-NET / Spoje-NET/php-abraflexi

Incorrect type annotations in \AbraFlexi\Exception class

Open
#52 0 comments 0 reactions 1 assignee View on GitHub

@Vitexus is already working on this.

Since Nov 19, 2024.

bug documentation good first issue invalid
Dominant language
PHP
Stars
24
Forks
13
No merged PRs in 30d

Description

Hello,

the $errorMessages property tn the \AbraFlexi\Exception class has an incorrect array<string> annotation, so do the getErrorMessages() and getErrorMessage() methods.

The getErrorMessages() method returns array of arrays like var_dumped below:

array(1) {
  [0]=>
  array(1) {
    ["message"]=>
    string(105) "Adresa https://server/c/company-name/faktura-vydana/xxx není platná."
  }
}

Introduced here: https://github.com/Spoje-NET/php-abraflexi/commit/23a0e127b1bb4589ce8d85b53f45e06ec71bf380#diff-6c213693e8ea3922558d3fe889351f27b5054c289a507fa15289c29d56e53285R30

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.