SpikeInterface / SpikeInterface/spikeinterface

Remove artifact function with explicit timestamps

Open
#619 9 comments 1 reaction 1 assignee View on GitHub

@alejoe91 is already working on this.

Since Jan 2, 2023.

enhancement
Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

RemoveArtifactsRecording takes as input list_triggers, which are in frames. On the other hand, ms_before and ms_after are in milliseconds. This is converted to frames using the sampling rate later. As a result, one cannot make use of ms_before and ms_after if one uses explicit timestamps (perhaps because there are missing samples in the recording). @alejoe91 @samuelgarcia what do you think about changing this such that get_times is used to infer the conversion from ms to frames? This means the padding must be computed separately for each trigger, so the performance may take a hit. Alternatively, could make the user specify frames_before and frames_after, which are computed manually before calling remove artifact.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.