SpikeInterface / SpikeInterface/spikeinterface
Letting Lupin pass job kwargs to motion correction.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 847
- Forks
- 280
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 29
Description
Hello,
I'm testing the Lupin sorter, and it seems that the motion correction step does not use parallelization.
Start correct_motion()
...
noise_level (no parallelization): 100%|██████████| 20/20 [00:08<00:00, 2.29it/s]
detect and localize (no parallelization): 0%|
is that expected?
The subsequent steps are fine.
Would it be possible to have Lupin pass job kwargs to motion correction?
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Lupin sorter entry point and trace its correct_motion() call, comparing it with the subsequent steps that already use parallelization. Done means Lupin can pass job kwargs into motion correction so that step no longer reports no parallelization; verify the behavior using the project’s existing coverage for this path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100