SpikeInterface / SpikeInterface/spikeinterface

`read_kilosort_as_analyzer` : read original `spike_templates.npy` instead of `spike_clusters.npy` from kilosort output

Open
#4,373 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

We should read the spike_templates.npy file in read_phy

Alternatively I propose to allow an argument to BasePhyKilosortSortingExtractor init that tells whether to try to use spike_clusters.npy if found or not and add an argument which was used.

The terminology should not be misleading because kilosort output can be manually refined by phy

https://github.com/SpikeInterface/spikeinterface/blob/25940b471ddefbfae038aff7a7db55e5386ccd4f/src/spikeinterface/extractors/phykilosortextractors.py#L341

https://github.com/SpikeInterface/spikeinterface/issues/4366#issuecomment-3854954921

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/spikeinterface/extractors/phykilosortextractors.py around line 341 and review the linked discussion in issue #4366. Determine whether the reader should use spike_templates.npy by default or expose an option for spike_clusters.npy, and clarify the terminology for manually refined Phy output. Done means the selected behavior and argument are consistently represented in the reader.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.