SpikeInterface / SpikeInterface/spikeinterface

Add `__del__` dunders to base classes

Open
#3,899 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core
Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

An idea that comes from here proposed by @alejoe91

https://github.com/SpikeInterface/spikeinterface/pull/3833#discussion_r2048471522

We should make the behavior of closing open file handles and memmaps explicit.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the discussion in PR #3833 and locate the base classes responsible for open file handles and memmaps. Determine the intended explicit closing behavior and verify that it is covered for each affected base class.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.