SpikeInterface / SpikeInterface/spikeinterface
The function "get_neuropixels_channel_groups" uses the wrong input
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 847
- Forks
- 280
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 29
Description
In "src/spikeinterface/extractors/neuropixels_utils.py" ,
The function "get_neuropixels_channel_groups" has the input as "num_channels=384, num_adcs=12". But it uses the "num_channels_per_adc" instead of "num_adcs".
Another thing worth mentioning, "num_channels_per_adc" and "num_adcs" are misleading in some places. For example, the "num_adcs" should be 12 and "num_channels_per_adc" should be 32 in neuropixels1.0 but num_channels_per_adc is set to be 12 and often replaces "num_adcs".
Hope to fix it soon.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/spikeinterface/extractors/neuropixels_utils.py at get_neuropixels_channel_groups and trace how num_channels, num_adcs, and num_channels_per_adc are used. Verify the Neuropixels 1.0 values stated in the issue, then make the parameter usage and naming consistent wherever this function relies on them; done means channel groups use the intended input and the terminology is no longer misleading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100