SpikeInterface / SpikeInterface/spikeinterface

Add a test for unevenly spaced time series

Open
#3,441 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

Previously the tests for time handling tested the unevenly spaced time series case by implicitly making all timeseries unevenly spaced (just as this is a more complex case than the usual evenly spaced, so if things worked for unevenly spaced they (should) work for even). See #3379

This was bad for two reasons:

  1. was confusing and implicitly tested something that should be explicit
  2. created 10GB+ array in memory 😆

This is an issue to add a new test to the test_time_handling.py to test unevenly spaced time series are well handled, at least in the main cases.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/spikeinterface/core/tests/test_time_handling.py and review the existing time-handling tests and the context in #3379. Add explicit coverage for unevenly spaced time series in the main cases without implicitly making every test unevenly spaced or creating a 10GB+ array. Done means the focused test file passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.